feat: extended Redis TLS and MinIO credential support#52
Merged
Conversation
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Helm template flexibility and S3-compatible credential support to unblock deployments with self-signed CAs and non-standard secret key names (e.g. RustFS operator).
extraVolumes/extraVolumeMountsto the deployment template, enabling users to mount additional volumes such as CA certificates for Redis TLS or S3/MinIO TLS verificationenvsupport to the deployment template, enabling individual env var injection withvalueFromreferences for mapping secret keys to different env var namesAWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEYas fallbacks for MinIO credentials in app config, since these are the standard S3-compatible env var names created by operators like RustFS ManagerCloses #51
Changes
Helm (
deployment.yaml,values.yaml)extraVolumeMountsblock inspec.containers[0].volumeMountsextraVolumesblock inspec.volumesenvblock inspec.containers[0](afterenvFrom)env,extraVolumes,extraVolumeMountsApp code (
src/config/minio.py)AliasChoicesonaccess_keyandsecret_keyfields soMINIO_ACCESS_KEYis tried first, falling back toAWS_ACCESS_KEY_ID(and likewise for the secret key)Tests (
tests/unit/test_minio_config.py)test_loads_from_aws_env_vars_as_fallback— verifiesAWS_*env vars work whenMINIO_*vars are absenttest_minio_vars_take_precedence_over_aws_vars— verifiesMINIO_*vars win when both are setget_clean_env()to also stripAWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEYfor test isolationTest plan
just test-unit)extraVolumes,extraVolumeMounts, andenvsetextraVolumes/extraVolumeMountsAWS_*env vars (e.g. RustFS operator secret)🤖 Generated with Claude Code