fix: non-zero exit on delete cancellation; remove unsupported routine delete#2
Merged
Conversation
…routine delete
- All delete commands (workout, folder) now return an error on
cancellation so the process exits non-zero, letting scripts detect
the no-op.
- Remove `routine delete` command and `DeleteRoutine` client method
entirely — the Hevy API has no DELETE /routines/{id} endpoint, so the
command always failed with NOT_FOUND.
Closes obay#4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug 1 fix: All delete commands (
workout delete,folder delete) now return an error when the user cancels the confirmation prompt, producing a non-zero exit code. Previously they returnednil(exit 0), making it impossible for scripts to detect cancellation.Bug 2 fix: Removed
routine deletecommand andDeleteRoutineAPI method entirely. The Hevy API does not expose aDELETE /routines/{id}endpoint (per the official API docs — only GET, POST, PUT are available for routines), so the command always failed withNOT_FOUND.Closes obay#4
Test plan
hevycli workout delete <id>, cancel → verify exit code is non-zerohevycli folder delete <id>, cancel → verify exit code is non-zerohevycli routine deleteno longer exists as a subcommandhevycli routine --help→ confirm delete is not listed