Jk/cumulus 4773#243
Merged
Jkovarik merged 19 commits intocumulus-infrafrom Apr 9, 2026
Merged
Conversation
Updates for Cumulus v21.3.1
changes for cumulus v21.3.2
Add dynamic_throttled_queues
Add docker to shell container, update outputs to add send_pan_task
jonvel
reviewed
Apr 8, 2026
| # Terraform | ||
| RUN \ | ||
| curl "https://releases.hashicorp.com/terraform/${TERRAFORM_VERSION}/terraform_${TERRAFORM_VERSION}_linux_amd64.zip" -o "terraform.zip" && \ | ||
| unzip terraform.zip && \ |
Collaborator
Author
There was a problem hiding this comment.
I'm not opposed to squelching the output for more compressed logs as a general good practice.
jonvel
reviewed
Apr 8, 2026
| RUN dnf install -y gcc gcc-c++ git make unzip zip jq | ||
|
|
||
| # Install Docker | ||
| RUN dnf install -y docker git make unzip zip jq gcc gcc-c++ |
Collaborator
Author
There was a problem hiding this comment.
Good catch - the docker redundancy and it should be resolved.
jonvel
reviewed
Apr 8, 2026
jonvel
reviewed
Apr 8, 2026
| # AWS CLI | ||
| RUN \ | ||
| curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64-$AWS_CLI_VERSION.zip" -o "awscliv2.zip" && \ | ||
| unzip awscliv2.zip && \ |
Collaborator
Author
There was a problem hiding this comment.
I'm assuming the original implementer had other opinions, however I tend to agree.
etcart
approved these changes
Apr 9, 2026
Collaborator
etcart
left a comment
etcart
left a comment
There was a problem hiding this comment.
tested this and it worked on my machine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging main + CUMULUS-4773 into
cumulus-infraThis will upgrade Cumulus to 21.3.2. Please note stack migration steps from Core when testing:
The lambda function name and log group name for this task are
<prefix>-CnmResponsewhich might conflict with the non-core version ofthe task if you set that up in your terraform. In order to successfully deploy
the core task you may need to either:
them.
NOTE: For cumulus core developer ci stacks you only need to import the log
group, since the lambda deployed in the example/cumulus-tf directory will be
renamed automatically.