Add support for filter chaining in filter blocks by GuillaumeGomez · Pull Request #984 · askama-rs/askama-old · GitHub

This repository was archived by the owner on Mar 11, 2025. It is now read-only.

Collaborator

GuillaumeGomez commented Mar 7, 2024

Follow-up of #959.

It allows to chain filters on filter blocks, making the feature much more useful. :)

With this, the feature will be complete.

GuillaumeGomez requested review from Kijewski and djc

March 7, 2024 18:13

GuillaumeGomez commented

View reviewed changes

testing/tests/filter_block.rs Outdated Show resolved Hide resolved

GuillaumeGomez commented

View reviewed changes

askama_parser/src/node.rs Show resolved Hide resolved

djc reviewed

View reviewed changes

askama_derive/src/generator.rs Outdated Show resolved Hide resolved

askama_parser/src/node.rs Outdated Show resolved Hide resolved

askama_derive/src/generator.rs Outdated Show resolved Hide resolved

askama_derive/src/generator.rs Outdated Show resolved Hide resolved

Collaborator Author

GuillaumeGomez commented Mar 8, 2024

Applied suggestions.

djc reviewed

View reviewed changes

askama_parser/src/lib.rs Outdated Show resolved Hide resolved

askama_parser/src/node.rs Outdated Show resolved Hide resolved

Collaborator Author

GuillaumeGomez commented Mar 8, 2024

Created a new Filter type in its own commit. It required to update a lot of tests, forcing me to remove the use Expr::* because of name conflict, it's mostly because of cases like this that I'm not a big fan matching on just variant names. 😉

djc reviewed

View reviewed changes

askama_parser/src/tests.rs Show resolved Hide resolved

Collaborator Author

GuillaumeGomez commented Mar 8, 2024

Fixed the commit mess. :)

djc reviewed

View reviewed changes

askama_parser/src/expr.rs Outdated Show resolved Hide resolved


          Create new Filter type

fb2a492

djc reviewed

View reviewed changes

askama_derive/src/generator.rs Outdated Show resolved Hide resolved

Collaborator Author

GuillaumeGomez commented Mar 8, 2024

Renamed and added documentation.

GuillaumeGomez added 3 commits

March 8, 2024 15:56


          Add support for filter chaining in filter blocks

72750eb


          Add test for filter block chaining

3a91afb


          Add documentation for filter chaining on filter block

e5dfe48

djc approved these changes

View reviewed changes

GuillaumeGomez merged commit 3026829 into askama-rs:main

GuillaumeGomez deleted the filter-doc-chaining branch

March 11, 2024 13:25

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet