docs: update hoist docs to mention pnpm-workspace.yaml#2899
Conversation
pnpm 11 does not read settings from .npmrc anymore.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e5a94a95c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| To make the behavior outside of Bazel match, we recommend adding `hoist: false` to your `pnpm-workspace.yaml`: | ||
|
|
||
| ```shell | ||
| echo "hoist=false" >> .npmrc | ||
| echo "hoist: false" >> pnpm-workspace.yaml |
There was a problem hiding this comment.
For users still on pnpm 9, this version-agnostic replacement no longer tells them how to disable hoisting: the repo still supports pnpm v9+ (npm_translate_lock requires lock_version at least 9.0 in npm/private/test/parse_pnpm_lock_tests.bzl, and e2e modules still pin pnpm_version = "9.15.9"), while the workspace-settings path is treated as pnpm v10+ in npm/private/npm_translate_lock_state.bzl. Those users will follow this new pnpm-workspace.yaml guidance and keep pnpm's hidden hoist folder enabled, so their local node_modules will not match rules_js; please keep the .npmrc instruction for pnpm 9 or call out the pnpm 10+/11-only behavior.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
pnpm 9.x docs are nowhere to be found. Suspect EOL?
1 participant
pnpm 11 does not read settings from .npmrc anymore (pnpm 10 already supports reading
hoistfrom pnpm-workspace.yaml).Note that there are likely many places to update in this repository itself.