Skip to content

fix: resolve npm package store tar toolchain as a Label #2900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbedard merged 1 commit into from
Jul 4, 2026
+3 −1
Merged

fix: resolve npm package store tar toolchain as a Label #2900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions e2e/repo_mapping/.bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import %workspace%/../../tools/preset.bazelrc
import %workspace%/../e2e.bazelrc

# Exercise action toolchain resolution when apparent repository names differ.
common --incompatible_auto_exec_groups
2 changes: 1 addition & 1 deletion npm/private/npm_package_store.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ def _npm_package_store_impl(ctx):
execution_requirements = {
"supports-path-mapping": "1",
},
toolchain = tar_lib.toolchain_type,
toolchain = Label("@tar.bzl//tar/toolchain:type"),

# Always override the locale to give better hermeticity.
# See https://github.com/aspect-build/rules_js/issues/2039
Expand Down
Loading