Skip to content

ci: ping a liveness heartbeat after successful fetch runs - #104

Merged
okisdev merged 1 commit into
mainfrom
obs/fetch-heartbeat
Aug 31, 2026
Merged

ci: ping a liveness heartbeat after successful fetch runs#104
okisdev merged 1 commit into
mainfrom
obs/fetch-heartbeat

Conversation

@okisdev

@okisdev okisdev commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

problem

the daily fetch workflow has no liveness signal independent of the repo itself: if the cron is disabled, the workflow file breaks, or GitHub stops scheduling it, nothing is left alive to report a failure (the Axiom telemetry step only reports runs that happen).

change

ping a Better Stack heartbeat (BETTERSTACK_HEARTBEAT_URL repo secret, already set) as the final step on successful runs only; a missing secret skips silently. the heartbeat expects one ping per day with a 6 hour grace window.

verification

yaml lints clean; the step degrades to a workflow warning when the ping fails.

Track in Rupic

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
modelpedia-web Ready Ready Preview Aug 31, 2026 5:20am

@rupic-app

rupic-app Bot commented Aug 31, 2026

Copy link
Copy Markdown

Comment Reviewed in 5m 19s · Round 1 · comment · 4bd89ae

Merge as is — external heartbeat closes the fetch workflow's liveness gap

The liveness gap is real and not covered by the existing Axiom telemetry: that signal is emitted only after the fetch job starts, while this change adds a final success()-guarded Better Stack ping using the workflow's established secret-skip and warning-on-curl-failure patterns (.github/workflows/fetch-models.yml:178-219). I found no conflicting implementation, unsafe adjacent behavior, test-harness requirement, or governance violation, so this PR is suitable to merge as-is.

Merge state: The PR is open and marked mergeable. The recorded CI state contains completed checks plus checks still in progress or queued; review-thread resolution and any gating human review state are unknown because no thread-state record is available.

Evidence · 2 verified · 2 not verified

Verified

  • The existing Axiom telemetry cannot detect a workflow that never starts.
    The repository contains no other heartbeat or liveness implementation.
  • A Better Stack heartbeat is attempted only after a successful run, without failing the workflow for a missing secret or failed ping.
    The control flow is directly established by the changed lines.

Not verified

  • The heartbeat monitor expects one ping per day with a six-hour grace window.
    The Better Stack monitor configuration would settle this operational claim.
  • The workflow YAML lints clean.
    An Action-aware YAML lint execution would settle the claim.

Read the full one-file diff, changed workflow, context pack, repository memories, sibling workflows, CONTRIBUTING.md, git history, PR status, and conversation context; searched the checkout for heartbeat and liveness primitives. No tests or PR code were executed. Prior-review and review-thread records were unavailable; the recorded CI state remained partially unsettled.

Round Commit Verdict Took When
1 4bd89ae comment 5m 19s 2026-08-31 05:24 UTC

Comment @rupic-app stop reviewing to stop reviewing this PR.

Review by Rupic.

@rupic-app rupic-app Bot added stage/needs-review No reviews yet; waiting for a maintainer R1 Actionable, normal priority type/chore Tooling, deps, CI, formatting size/S 10–49 lines changed labels Aug 31, 2026
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
modelpedia-api 4bd89ae Commit Preview URL

Branch Preview URL
Aug 31 2026, 05:19 AM

@okisdev
okisdev merged commit 9c5cdf9 into main Aug 31, 2026
11 checks passed
@okisdev
okisdev deleted the obs/fetch-heartbeat branch August 31, 2026 05:26
@rupic-app rupic-app Bot added stage/merged Merged into the default branch and removed stage/needs-review No reviews yet; waiting for a maintainer R1 Actionable, normal priority labels Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S 10–49 lines changed stage/merged Merged into the default branch type/chore Tooling, deps, CI, formatting

Development

Successfully merging this pull request may close these issues.

1 participant