Skip to content

ci: drop the axiom pipeline telemetry - #108

Merged
okisdev merged 1 commit into
mainfrom
ci/drop-axiom-telemetry
Aug 31, 2026
Merged

ci: drop the axiom pipeline telemetry#108
okisdev merged 1 commit into
mainfrom
ci/drop-axiom-telemetry

Conversation

@okisdev

@okisdev okisdev commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

problem

the axiom pipeline telemetry (#103, #107) monitored the symptom: it would page when the daily data PR sat unmerged past 48h, but a human still had to go merge it. the direction is now to remove the human step entirely (auto-merge logic, likely via rupic, with pricing sanity moved into validate.ts as a merge gate), which makes the staleness monitoring layer moot before its dataset was ever provisioned.

change

remove both axiom reporting steps (pipeline.run/pipeline.provider in fetch-models, model.change in changes). the Better Stack heartbeat stays: it answers "is the pipeline alive at all", which auto-merge logic depends on too and cannot report on its own.

verification

yaml lints clean; both steps were no-ops in production anyway (the AXIOM_TOKEN secret was never provisioned, so every run skipped them).

Track in Rupic

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
modelpedia-web Ready Ready Preview Aug 31, 2026 7:23am

@rupic-app

rupic-app Bot commented Aug 31, 2026

Copy link
Copy Markdown

Comment Reviewed in 7m 28s · Round 1 · comment · 8c0647b

Close or redirect — Telemetry removal is premature without auto-merge or replacement alerting

This PR should be closed or redirected because its stated replacement is absent: .github/workflows/fetch-models.yml:128-172 still creates or updates an open data PR, and the remaining heartbeat at :174-183 reports only workflow liveness. Removing the Axiom events therefore leaves the nonfatal provider and staleness paths without the alerting behavior that motivated them; the local failure summary is conditional on a changed PR.

  • Please close this cleanup or pair it with the auto-merge and replacement-alert change, retaining an equivalent stale-PR and provider-failure signal until that replacement is present.

Claims that did not hold

  • Auto-merge makes the staleness monitoring layer moot
    The repository does not contain the automation that would make stale-PR monitoring redundant.

Blocking

  • .github/workflows/fetch-models.yml — The PR removes the monitoring layer on the premise that auto-merge will remove the stale-PR problem, but the head contains no auto-merge path: .github/workflows/fetch-models.yml:128-172 still creates or edits an open PR. Better Stack at :174-183 only detects a missing successful run. Please close or redirect this cleanup to the change that adds auto-merge or an equivalent replacement monitor.
  • .github/workflows/fetch-models.yml — The workflow intentionally catches provider failures and keeps the job green at .github/workflows/fetch-models.yml:70-89; the diagnostics at :107-117 are also non-blocking. Deleting the Axiom event removes the only centralized failedProviders and per-provider report, while the heartbeat can still succeed and the PR-body copy is conditional on a changed catalog. Please retain or replace this failure alert before removing the telemetry.

Merge state: The PR is open and mergeable. The live check rollup has 8 completed checks (7 success and 1 neutral) and 1 in progress. The human review summary is empty; unresolved review-thread state is unknown because no thread data was supplied.

Evidence · 3 verified · 2 not verified

Verified

  • The change removes both Axiom reporting paths while keeping the Better Stack heartbeat
    The requested deletion and heartbeat retention are directly visible in the head and diff.
  • The former Axiom telemetry measured stale data and provider health
    The base-version block shows the telemetry's actual fields and its intended monitoring inputs.
  • The Better Stack heartbeat answers whether the pipeline is alive
    This verifies liveness monitoring, not stale-PR or per-provider monitoring.

Not verified

  • The YAML lints clean
    A YAML linter result would settle this claim; no YAML linter was executed in this review.
  • AXIOM_TOKEN was never provisioned, so every run skipped the telemetry
    GitHub secret configuration or historical workflow logs would settle whether the steps were no-ops in production.

Read the full diff and both changed workflows, the fetch/change support scripts, package manifests, CONTRIBUTING.md, repository memory, and local history. Searched for Axiom pipeline consumers and auto-merge paths, and refreshed the live PR state: 8 checks completed and 1 remains in progress. Did not execute tests or PR code; only git diff --check was run. No prior review or thread file was present.

Round Commit Verdict Took When
1 8c0647b comment 7m 28s 2026-08-31 07:30 UTC

Comment @rupic-app stop reviewing to stop reviewing this PR.

Review by Rupic.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 31, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
modelpedia-api 8c0647b Commit Preview URL

Branch Preview URL
Aug 31 2026, 07:23 AM

@rupic-app rupic-app Bot added stage/needs-review No reviews yet; waiting for a maintainer R1 Actionable, normal priority type/chore Tooling, deps, CI, formatting size/M 50–199 lines changed labels Aug 31, 2026
@okisdev
okisdev merged commit 21b91fd into main Aug 31, 2026
11 checks passed
@okisdev
okisdev deleted the ci/drop-axiom-telemetry branch August 31, 2026 07:31
@rupic-app rupic-app Bot added stage/merged Merged into the default branch and removed stage/needs-review No reviews yet; waiting for a maintainer R1 Actionable, normal priority labels Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M 50–199 lines changed stage/merged Merged into the default branch type/chore Tooling, deps, CI, formatting

Development

Successfully merging this pull request may close these issues.

1 participant