Refactor code and remove unused imports#164
Closed
Nicole4Fox wants to merge 1 commit into
Closed
Conversation
domai-tb
requested changes
Apr 7, 2024
domai-tb
left a comment
domai-tb
left a comment
Member
There was a problem hiding this comment.
Please implement a feature before requesting a merge. You can use the Draft PR feature of GitHub to convert your PR into a draft while developing.
Member
There was a problem hiding this comment.
Deprecated analysis options are already addressed in #160
| : (context, child) { | ||
| return MediaQuery(data: MediaQuery.of(context).copyWith(textScaleFactor: 1), child: child!); | ||
| return MediaQuery( | ||
| data: MediaQuery.of(context).copyWith(textScaler: TextScaler.noScaling), |
Member
There was a problem hiding this comment.
Good point. This was already adressed within #160 but I forgot to check the migration guide.
Note: https://docs.flutter.dev/release/breaking-changes/deprecate-textscalefactor#examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some small fixes - some refactoring and some unused imports. Also some small updates to readme.