Improve WebVTT to TTML conversion#132
Merged
asticode merged 4 commits intoNov 4, 2025
Merged
Conversation
asticode
requested changes
Nov 4, 2025
Contributor
Author
|
Thanks for reviewing this PR! The commit e6a64eb should address your concerns. |
asticode
requested changes
Nov 4, 2025
asticode
left a comment
asticode
left a comment
Owner
There was a problem hiding this comment.
A couple of minor changes needed 👍
Owner
|
Thanks for the PR and the quick changes ❤️ FYI I've created a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle colors and positions while converting WebVTT to TTML (yes we have this usecase).
In VTT testdata, the change of "start" to "line-left" has been done because "start" is not a legal value here.