-
Notifications
You must be signed in to change notification settings - Fork 127
Feat/streaming optimization #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mysamimi
wants to merge
25
commits into
asticode:master
Choose a base branch
from
mysamimi:feat/streaming-optimization
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
1e7c16b
use item index in WriteToWebVTT
969140e
test repo
102b36b
rev test repo
d2f7670
fix index in Order method
abc0985
remove index plus one!
820c2cb
add FixIndex for Items
9abe444
fix unnessery change
4ae3e61
fix
82e090d
fix bad build test & add ClipFrom, ClipTo method
aa08cba
overload WriteToWebVTT, 2 arg force use item index
d6b6e46
remove change in Order method
f8731f9
add new tests, fix bug :)
b0e80b6
fix clipFrom
44a67b7
fix clipFrom
06b2226
add clone method
2d08a66
Merge branch 'master' of https://github.com/asticode/go-astisub into …
mysamimi b0feb66
Merge branch 'asticode-master'
mysamimi 4776701
Merge remote-tracking branch 'upstream/master'
mysamimi 764fc08
feat: optimize writers with streaming and upgrade to Go 1.24
mysamimi 8fd230f
chore: Update Go version to 1.24 in the test workflow.
mysamimi fa8dbf1
refactor: use astikit.WriteChainer for robust write operations in sub…
mysamimi 914aeaf
Merge remote-tracking branch 'upstream/master' into feat/streaming-op…
mysamimi a2d8524
Revert Go version to 1.13 and cleanup webvtt comments
mysamimi 266762f
Align WriteToWebVTT signature and logic with upstream master
mysamimi 932f2c7
refactor: wrap write errors with contextual information in SSA and SR…
mysamimi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,17 @@ | ||
| module github.com/asticode/go-astisub | ||
|
|
||
| go 1.13 | ||
| go 1.24.0 | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems your "revert to go 1.13" change was reverted by one of the last commit. Could you revert it back? |
||
|
|
||
| require ( | ||
| github.com/asticode/go-astikit v0.20.0 | ||
| github.com/asticode/go-astits v1.8.0 | ||
| github.com/asticode/go-astikit v0.58.0 | ||
| github.com/asticode/go-astits v1.15.0 | ||
| github.com/stretchr/testify v1.4.0 | ||
| golang.org/x/net v0.0.0-20200904194848-62affa334b73 | ||
| golang.org/x/text v0.3.2 | ||
| golang.org/x/net v0.49.0 | ||
| golang.org/x/text v0.33.0 | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/davecgh/go-spew v1.1.0 // indirect | ||
| github.com/pmezard/go-difflib v1.0.0 // indirect | ||
| gopkg.in/yaml.v2 v2.2.2 // indirect | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.