Merge the feature branch used in the astra-sim submodule into main#7
Open
Mekapaedia wants to merge 17 commits intoastra-sim:mainfrom
Open
Merge the feature branch used in the astra-sim submodule into main#7Mekapaedia wants to merge 17 commits intoastra-sim:mainfrom
Mekapaedia wants to merge 17 commits intoastra-sim:mainfrom
Conversation
… cache), solve const problems, move template implemenattion to header
…pported F->T pairs, update unsupported old binary compares
…without seeing whole feeder def (avoid compile warnings)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the commits that are actually present in the commit hash used in the submodule of chakra within astra-sim are contained within this feature branch - plus some fixes. It makes sense to merge most, if not all; of these changes into the main of the fork so it's more obvious how to access the changes (and makes upstreaming easier)