Add debug logging for exclude-newer filtering #16606
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
reviewed
Nov 6, 2025
| /// The returned [`Candidate`] _may not_ be compatible with the current platform; in such | ||
| /// cases, the resolver is responsible for tracking the incompatibility and re-running the | ||
| /// selection process with additional constraints. | ||
| #[allow(unused_variables)] // exclude_newer is unused here, logging handled at higher level |
Member
There was a problem hiding this comment.
I don't understand why we need to pass it through here if it's not used here?
zanieb
reviewed
Nov 6, 2025
Comment on lines
+1288
to
+1290
| debug!( | ||
| "Excluding candidates for {name} published after {exclude_newer_ts}" | ||
| ); |
Member
There was a problem hiding this comment.
Is this being logged if exclude newer is set and we visit this package? That seems misleading? Shouldn't we only log it if we actually filtered a distribution due to exclude newer?
Why should we have this in a debug log rather than a hint on failed resolution?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When
exclude-newerfilters out all candidates for a package, the debug output doesn't indicate that the date filter was applied. This makes it difficult to diagnose why no compatible versions are found. Issue described here: #16485Example scenario:
mlx==0.29.3(published on 2025-10-18)exclude-newer = "2025-10-11T00:00:00Z"New output:
Test Plan
Tested with:
Running
uv lock -vvvnow shows the exclude-newer debug message.