Skip to content

Added near meridian constraint#589

Open
ramonefoster wants to merge 9 commits intoastropy:mainfrom
ramonefoster:add-near-meridian-contraint
Open

Added near meridian constraint#589
ramonefoster wants to merge 9 commits intoastropy:mainfrom
ramonefoster:add-near-meridian-contraint

Conversation

@ramonefoster
Copy link

Created NearMeridianContraint, that can be useful for observations using German-Equatorial Mounts, to avoid flipping the side of pier during exposures.

@ramonefoster ramonefoster force-pushed the add-near-meridian-contraint branch from da62738 to db11881 Compare August 9, 2024 18:59
Copy link
Contributor

@bmorris3 bmorris3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ramonefoster, this is great!

My only real comment is about the name. When you first read it, it may be a bit ambiguous if this constraint includes or excludes targets are near the meridian.

Could we rename it MeridianSeparationConstraint, and add a max keyword argument? This would make it clear that the constraint sets angular limits relative to the meridian.

@ramonefoster
Copy link
Author

Hello, @bmorris3 . Thanks for the suggestion, it was indeed a needed change. I have it fixed.

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.11%. Comparing base (a4d89a0) to head (d0bf8d4).

Files with missing lines Patch % Lines
astroplan/constraints.py 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
+ Coverage   72.90%   73.11%   +0.20%     
==========================================
  Files          14       14              
  Lines        1849     1856       +7     
==========================================
+ Hits         1348     1357       +9     
+ Misses        501      499       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants