Conversation
da62738 to
db11881
Compare
There was a problem hiding this comment.
Thanks @ramonefoster, this is great!
My only real comment is about the name. When you first read it, it may be a bit ambiguous if this constraint includes or excludes targets are near the meridian.
Could we rename it MeridianSeparationConstraint, and add a max keyword argument? This would make it clear that the constraint sets angular limits relative to the meridian.
|
Hello, @bmorris3 . Thanks for the suggestion, it was indeed a needed change. I have it fixed. |
Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
…nefoster/astroplan into add-near-meridian-contraint
…near-meridian-contraint
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #589 +/- ##
==========================================
+ Coverage 72.90% 73.11% +0.20%
==========================================
Files 14 14
Lines 1849 1856 +7
==========================================
+ Hits 1348 1357 +9
+ Misses 501 499 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Created NearMeridianContraint, that can be useful for observations using German-Equatorial Mounts, to avoid flipping the side of pier during exposures.