ENH: Add AltAzTarget and support time-dependent targets#634
Open
michaelbaisch wants to merge 4 commits intoastropy:mainfrom
Open
ENH: Add AltAzTarget and support time-dependent targets#634michaelbaisch wants to merge 4 commits intoastropy:mainfrom
michaelbaisch wants to merge 4 commits intoastropy:mainfrom
Conversation
- Add AltAzTarget for targets defined in horizontal coordinates at a fixed EarthLocation, evaluated to time-dependent ICRS SkyCoord when needed; support vacuum (pressure=0) and apparent (pressure>0) interpretations via stored atmospheric parameters. - Export AltAzTarget and make get_skycoord(time-aware): accept `times`, evaluate time-dependent targets via get_skycoord(times), and broadcast coords. - Pass `time` into get_skycoord from Observer._preprocess_inputs to enable time-dependent target evaluation during constraint calculations. - Update Constraint.__call__ to delegate gridding and time-dependent evaluation to Observer._preprocess_inputs. - In scheduling add `target_type`/`target_info` columns in Schedule.to_table. - Add tests.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
==========================================
+ Coverage 72.90% 74.60% +1.69%
==========================================
Files 14 14
Lines 1849 1953 +104
==========================================
+ Hits 1348 1457 +109
+ Misses 501 496 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…SkyCoord targets when checking for multiple targets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
times, evaluate time-dependent targets via get_skycoord(times), and broadcast coords.timeinto get_skycoord from Observer._preprocess_inputs to enable time-dependent target evaluation during constraint calculations.target_type/target_infocolumns in Schedule.to_table.#566 was updated to be compatible with this PR.