fix: skip metrics submission on fatal generation errors (fixes #2010)#2127
Open
armorbreak001 wants to merge 1 commit intoasyncapi:masterfrom
Open
fix: skip metrics submission on fatal generation errors (fixes #2010)#2127armorbreak001 wants to merge 1 commit intoasyncapi:masterfrom
armorbreak001 wants to merge 1 commit intoasyncapi:masterfrom
Conversation
…pi#2010) When a command fails with an error, the finally() handler still attempted to submit anonymous usage metrics, which could fail and produce a misleading secondary error message. Skip metrics recording entirely on failure so only the actual error is shown to the user.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a command fails with an error, the
finally()handler still attempted to submit anonymous usage metrics viarecordActionFinished(). This could fail independently (e.g. network error when flushing to NewRelic), producing a misleading secondary error message that obscures the actual cause of failure.Changes
src/apps/cli/internal/base.ts: Infinally(), return early whenerroris set instead of proceeding to record metrics. This ensures only the real error is shown to the user.Reproduction (from issue)
Before: Two errors — the real one plus
Skipping submitting anonymous metrics due to the following error: TypeError: fetch failedAfter: Only the actual generator error is displayed.