Skip to content

fix: prevent double-stringification of AsyncAPI string in archiver service (#2026) #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
useye wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

fix: prevent double-stringification of AsyncAPI string in archiver service (#2026) #2134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/domains/services/archiver.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,11 @@

public appendAsyncAPIDocument(
archive: Archiver,
asyncapi: string,
asyncapi: string | object,
fileName = 'asyncapi',
) {
asyncapi = JSON.stringify(asyncapi);
const content =

Check warning on line 33 in src/domains/services/archiver.service.ts

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Remove this useless assignment to variable "content". 


See more on https://sonarcloud.io/project/issues?id=asyncapi_cli&issues=AZ2ziXu5cqBHkekLkntT&open=AZ2ziXu5cqBHkekLkntT&pullRequest=2134
typeof asyncapi === 'string' ? asyncapi : JSON.stringify(asyncapi);
const language = retrieveLangauge(asyncapi);
if (language === 'yaml') {
archive.append(asyncapi, { name: `${fileName}.yml` });
Expand Down
Loading