fix: github URL parsing for slash-based branches and multi-dot filenames#2137
Open
BossChaos wants to merge 2 commits intoasyncapi:masterfrom
Open
fix: github URL parsing for slash-based branches and multi-dot filenames#2137BossChaos wants to merge 2 commits intoasyncapi:masterfrom
BossChaos wants to merge 2 commits intoasyncapi:masterfrom
Conversation
BossChaos
requested review from
AayushSaini101,
Amzani,
Shurtu-gal,
Souvikns and
asyncapi-bot-eve
as code owners
🦋 Changeset detectedLatest commit: 6e57522 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2 tasks
- Update GitHub blob URL regex to support branch names with slashes
- Use path.extname() instead of split('.') for reliable file extension detection
- Fix Issue asyncapi#1940
Co-authored-by: Adma 機械人 <adma@hermes.agent>
BossChaos
force-pushed
the
fix/url-parsing-and-extension-detection-1940
branch
from
b1d34d8 to
6e57522
Compare
|
BossChaos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Issue #1940 - Two validation bugs causing valid inputs to fail.
Changes
1. GitHub URL Parsing (validation.service.ts)
([^\/]+)assumed branch names contain no slashes(.+?)supports branch names with slashes (e.g.,feature/new-validation)2. File Extension Detection (SpecificationFile.ts)
name.split(".")[1]failed for multi-dot filenamespath.extname(name).slice(1)correctly handlesmy.asyncapi.yamlTesting
Tested with:
https://github.com/org/repo/blob/feature/new-validation/spec.yamlmy.asyncapi.yamlRelated
Fixes #1940