Admit dynamic load and delete operands - #3028
Merged
rogeralsing merged 1 commit intoJun 1, 2026
Merged
Conversation
rogeralsing
deleted the
codex/unified-bytecode-loop-68-dynamic-load-delete
branch
June 1, 2026 23:07
There was a problem hiding this comment.
Pull request overview
This PR widens the production unified-bytecode routing to admit additional “ordinary dynamic” environment operations, specifically dynamic identifier loads and first-boundary computed-property deletes with dynamic identifier keys, and adds regression coverage plus contract documentation updates.
Changes:
- Expanded unified-bytecode eligibility checks to allow first-boundary computed
delete obj[key]wherekeyis an ordinary dynamic identifier (when enabled by activation descriptor). - Updated eligibility and invocation tests to validate the new fast-path/eligibility behavior for dynamic identifier loads and dynamic-key computed deletes.
- Updated the unified-bytecode expansion contract to point to the new/renamed proof tests for dynamic lookup and delete lanes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/Asynkron.JsEngine.Tests/UnifiedBytecodeProductionInvocationTests.cs | Adds direct fast-path route-hit tests for dynamic identifier reads and dynamic-key computed deletes. |
| tests/Asynkron.JsEngine.Tests/UnifiedBytecodeProductionEligibilityTests.cs | Updates eligibility assertions to accept ordinary dynamic identifier operations and validates resulting opcodes. |
| src/Asynkron.JsEngine/Execution/UnifiedBytecode/UnifiedBytecodeProductionEligibility.cs | Threads an “allow ordinary dynamic identifiers” flag into computed-delete candidate checks and computed-key validation. |
| docs/unified-bytecode-expansion-contract.md | Refreshes proof pointers for the dynamic-lookup and delete lanes reflecting the updated contract. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2979
to
+2981
| Assert.Equal(UnifiedBytecodeProductionDeclineCode.None, (UnifiedBytecodeProductionDeclineCode)expectedCode); | ||
| Assert.True(result.IsEligible, result.Reason); | ||
| Assert.Equal(UnifiedBytecodeProductionDeclineCode.None, result.Code); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification