-
Notifications
You must be signed in to change notification settings - Fork 6
Native dead returns and unused bindings removal transformers #888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
OscarCookeAbbott
wants to merge
25
commits into
main
Choose a base branch
from
oscar/js-transformer/native-dead-code-elim
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Native dead returns and unused bindings removal transformers #888
OscarCookeAbbott
wants to merge
25
commits into
main
from
oscar/js-transformer/native-dead-code-elim
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement new `unused_bindings_remover` transformer Hook up transformers using env to enable/disable
…arios and preserve bindings in tests
Refactor and clean up `unused_bindings_remover` Add a lot more tests
Add import cleaning tests
🦋 Changeset detectedLatest commit: 6724864 The changes in this PR will be included in the next version bump. This PR includes changesets to release 75 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
📊 Type Coverage ReportCoverage Comparison
Files with Most Type Issues (Top 15)
This report was generated by the Type Coverage GitHub Action |
Contributor
📊 Benchmark Results✅ No significant performance changes detected. 📊 Benchmark ResultsOverall Performance
🔍 Detailed Phase AnalysisThree.js Real Repository (JS)
Three.js Real Repository (Native)
💾 Unified Memory AnalysisThree.js Real Repository (JS) Memory Statistics
Sample Counts: JS: 6, Native: 267 Three.js Real Repository (Native) Memory Statistics
Sample Counts: JS: 6, Native: 578 🖥️ Environment
|
marcins
reviewed
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is an initial, successful version of some dead code elimination transformers to replace Babel transformers in Jira SSR.
The transformers successfully replace the Babel original's functionally (successful build and SSR render) but is likely to see a small followup PR in future to get the output aesthetically as close to 1:1 as possible (less comment removal/addition, perhaps some other small changes).
All new functionality is opt-in via env config as with my previous transformers, so they will not adversely affect any other projects.
Changes
dead_returns_removertransformer and hook up via opt-in flagunused_bindings_removertransformer and hook up via opt-in flagChecklist
docs/folder