-
Notifications
You must be signed in to change notification settings - Fork 6
Implement full native tokens plugin, use common code #897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: d2275be The changes in this PR will be included in the next version bump. This PR includes changesets to release 110 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📊 Type Coverage ReportCoverage Comparison
Files with Most Type Issues (Top 15)
This report was generated by the Type Coverage GitHub Action |
📊 Benchmark Results📊 Benchmark ResultsOverall Performance
🔍 Detailed Phase AnalysisThree.js Real Repository (JS)
Three.js Real Repository (V3)
💾 Unified Memory AnalysisThree.js Real Repository (JS) Memory Statistics
Sample Counts: JS: 14, Native: 294 Three.js Real Repository (V3) Memory Statistics
Sample Counts: JS: 14, Native: 701 🖥️ Environment
|
3ee3968 to
b6bbf1a
Compare
|
Worked eventually? |
crates/atlaspack_plugin_transformer_tokens/src/tokens_transformer.rs
Outdated
Show resolved
Hide resolved
f684ec8 to
d2275be
Compare
Motivation
The bulk of the
@atlaspack/transformer-tokensplugin is native code, with a thin-ish JS wrapper to make it work as a JS plugin. For native asset graph we don't need this JS wrapper, it just adds unnecessary overhead, so we should instead just make it a fully native "plugin" like some of the other code plugins already in Atlaspack.Changes
atlaspack_atlaskit_tokenscrateplugin_tokensin Node bindings to use the shared crateatlaspack_plugin_transformer_tokenscrate to use shared crate with a native implementationChecklist
docs/folder