Add unstable_alias and fix alias self references #898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f0c7821 The changes in this PR will be included in the next version bump. This PR includes changesets to release 109 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mattcompiles
commented
Nov 20, 2025
| self.map.get(specifier) | ||
| } | ||
|
|
||
| pub fn resolve_alias(&self, specifier: &Specifier) -> Option<Cow<'_, AliasValue>> { |
Contributor
Author
There was a problem hiding this comment.
The diff makes this look like all new code but it's just mostly moved from package_json.rs
mattcompiles
commented
Nov 20, 2025
| && path == self.from | ||
| { | ||
| // Don't resolve alias that points to itself. | ||
| return Ok(None); |
Contributor
Author
There was a problem hiding this comment.
This is the circular self reference fix
Contributor
📊 Type Coverage ReportCoverage Comparison
Files with Most Type Issues (Top 15)
This report was generated by the Type Coverage GitHub Action |
Contributor
📊 Benchmark Results🎉 Performance improvements detected! 📊 Benchmark ResultsOverall Performance
🔍 Detailed Phase AnalysisThree.js Real Repository (JS)
Three.js Real Repository (Native)
💾 Unified Memory AnalysisThree.js Real Repository (JS) Memory Statistics
Sample Counts: JS: 6, Native: 284 Three.js Real Repository (Native) Memory Statistics
Sample Counts: JS: 6, Native: 648 🖥️ Environment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes to the node resolver:
alias.rsfileunstable_aliaswhich allows you to configure build specific aliases, rather than project wide onesunstable_aliasTo remove our reliance on custom resolvers, this PR adds a new
unstable_aliasfeature which let's you configure resolver aliases in the.parcelrc. The feature is currently a little half-baked as it's only supported in V3 builds and doesn't support config extending (only the top-level .parcelrc will be used). I've only added it to V3 as you'd have add code to each resolver plugin to make it work and the intention is to move away from custom resolvers, not add to them.I didn't bother with extension support as this is really just a stepping stone feature before we get to the config file reboot. Outside of this above, the aliasing features should work as exactly the same as the one defined in package.json.
You can also continue to use the package.json ones alongside the
unstable_aliasones. You'd want to do this if you have aliases that are actually valid for the whole project.Checklist