Implement native react_async_import_lift transformer
#902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hook up transformer using env to enable/disable
Hook up transformer using env to enable/disable
Hook up transformer using env to enable/disable
…aliaser` transformer
Implement new `unused_bindings_remover` transformer Hook up transformers using env to enable/disable
…arios and preserve bindings in tests
Refactor and clean up `unused_bindings_remover` Add a lot more tests
Add import cleaning tests
Small improvements
- Add config cache - Add tests
…nto oscar/js-transformer/react-async-import-lift
🦋 Changeset detectedLatest commit: 24f5fc1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 110 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Rust Package Changeset Check✅ The |
Contributor
📊 Type Coverage ReportCoverage Comparison
Files with Most Type Issues (Top 15)
This report was generated by the Type Coverage GitHub Action |
marcins
approved these changes
Nov 25, 2025
Contributor
|
You've got a bunch of Clippy errors to resolve, and you'll need to merge in |
…nsformer/react-async-import-lift
…nsformer/react-async-import-lift
Base automatically changed from
oscar/js-transformer/rest-of-the-owl
to
main
November 27, 2025 02:56
marcins
approved these changes
Nov 27, 2025
| @@ -437,7 +436,7 @@ pub fn transform( | |||
| unresolved_mark, | |||
| &config.sync_dynamic_import_config, | |||
| )), | |||
| config.is_tesseract && config.sync_dynamic_import_config.is_some()), | |||
| config.sync_dynamic_import_config.is_some()), | |||
Contributor
There was a problem hiding this comment.
Was the config.is_tesseract since I last reviewed removed intentionally?
Contributor
Author
There was a problem hiding this comment.
Yeah it was from a prior version of Nathan's branch that he later changed, when I merged in main after that Git didn't know that had happened so it and a few other random lines hung around that I have just now realised and removed.
| @@ -124,15 +124,15 @@ impl ReactAsyncImportLift { | |||
| }); | |||
|
|
|||
| // Replace import() with the lifted identifier in the expression tree | |||
| self.replace_import_with_ident(expr, &lifted_id); | |||
| Self::replace_import_with_ident(expr, &lifted_id); | |||
Contributor
There was a problem hiding this comment.
What is the reason for this change from self. to Self::? Is it some "method doesn't actually use self so can be static" check?
Contributor
Author
There was a problem hiding this comment.
Yep. The &self function params in a few functions were redundant since I had changed how the functions worked but had forgotten to remove them.
Contributor
📊 Benchmark Results✅ No significant performance changes detected. 📊 Benchmark ResultsOverall Performance
🔍 Detailed Phase AnalysisThree.js Real Repository (JS)
Three.js Real Repository (V3)
💾 Unified Memory AnalysisThree.js Real Repository (JS) Memory Statistics
Sample Counts: JS: 14, Native: 284 Three.js Real Repository (V3) Memory Statistics
Sample Counts: JS: 14, Native: 538 🖥️ Environment
|
OscarCookeAbbott
deleted the
oscar/js-transformer/react-async-import-lift
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are replacing various old Babel transformers with native reimplementations for performance and maintenance reasons.
Changes
react_async_import_lifttransformerlib.rsChecklist
docs/folder