fix(docker): repair Build & Push (removed-module COPYs + image name) - #103
Merged
Conversation
…hub/simapp The Build & Push workflow fails with `"/log/go.sum": not found` because the Dockerfile still copies go.mod/go.sum for collections, store, and log — non-forked modules removed in #22/#25. Remove those COPY lines (the main module's go mod download no longer needs them). Also rename the published image from ghcr.io/cosmos/simapp to ghcr.io/atomone-hub/simapp, since the cosmos namespace isn't writable by this org (the build failed before reaching the push, so this was latent).
giunatale
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Build & Push workflow (
docker.yml) fails on everymainpush and on release tags:The
Dockerfilestill copiesgo.mod/go.sumforcollections,store, andlog— non-forked modules that were removed in #22/#25. The build fails on the first missing one. This has been broken since those modules were removed; it surfaced loudly on thev0.500.0tag.Fix
COPY <module>/go.mod <module>/go.sumlines. The main module'sgo mod downloaddoesn't reference them (no localreplaceto those dirs), andCOPY . .still brings the full source formake build.ghcr.io/cosmos/simapp→ghcr.io/atomone-hub/simapp(thecosmosghcr namespace isn't writable by this org; the build failed before the push, so this was latent). Adjust the name if you'd prefer something else.CI on this PR runs the docker build (
push: falsefor PRs), so it verifies the Dockerfile builds.Surfaced while finalizing #90.