Skip to content

fix!: cherry-pick 19038 and add tests - #108

Merged
julienrbrt merged 3 commits into
mainfrom
julien/cherry-pick-19038
Jul 27, 2026
Merged

fix!: cherry-pick 19038 and add tests#108
julienrbrt merged 3 commits into
mainfrom
julien/cherry-pick-19038

Conversation

@julienrbrt

Copy link
Copy Markdown
Collaborator

Description

Cherry-pick 19038 and add more tests to harden the feature.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt
julienrbrt marked this pull request as ready for review July 27, 2026 10:17
@julienrbrt
julienrbrt merged commit 5d8a728 into main Jul 27, 2026
21 checks passed
@julienrbrt
julienrbrt deleted the julien/cherry-pick-19038 branch July 27, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants