chore: bump cosmos-sdk to v0.500.1 + CHANGELOG - #348
Merged
Conversation
The final SDK release added AfterConsensusPubKeyUpdate to the StakingHooks interface (consensus pubkey rotation). Implement it as a no-op in x/coredaos to satisfy the interface.
tbruyelle
changed the title
Export MigrateStakingParams and add a test that runs it against a test app, reproducing the post-RunMigrations state where KeyRotationFee is the zero-value Coin and asserting the migration sets a valid 1 ATONE fee in the bond denom (plus the 5% commission migration).
tbruyelle
force-pushed
the
chore/bump-sdk-v0.500-final
branch
from
June 23, 2026 06:43
bb8a086 to
4e6065a
Compare
MsgRotateConsPubKey funds the community pool with the KeyRotationFee via the staking keeper's distributionKeeper, which was never set in the app wiring, causing a nil-pointer panic (caught by TestAppStateDeterminism).
tbruyelle
force-pushed
the
chore/bump-sdk-v0.500-final
branch
from
June 23, 2026 08:57
76b9b05 to
0b3cc72
Compare
giunatale
approved these changes
Jun 23, 2026
julienrbrt
reviewed
Jun 23, 2026
| params.MaxCommissionRate = fivePercent | ||
| params.MinCommissionRate = fivePercent | ||
|
|
||
| // Initialize the consensus pubkey rotation fee to 1 ATONE, denominated in the chain bond denom. |
Collaborator
There was a problem hiding this comment.
any reason to not put it way more expensive? this operations imho should not happen so often, and we try should to avoid a validator rotating key each block
Collaborator
Author
There was a problem hiding this comment.
Thanks for the remind, I raised the value to 100 ATONEs 8bade79
go env GOVERSION embeds the toolchain's baked-in experiments (e.g. go1.26.4-X:nodwarf5 on Arch Linux's go package), which made check_go_version fail despite a correct version. Strip both the leading 'go' and the '-X:...' suffix so the comparison matches go.mod.
julienrbrt
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compat with consensus key rotation: