Skip to content

[WIP] Add Firefox support#216

Draft
zurgeg wants to merge 20 commits into
auchenberg:masterfrom
zurgeg:firefox-support
Draft

[WIP] Add Firefox support#216
zurgeg wants to merge 20 commits into
auchenberg:masterfrom
zurgeg:firefox-support

Conversation

@zurgeg

@zurgeg zurgeg commented Sep 1, 2021

Copy link
Copy Markdown

Fixes #215

Currently, the way this works breaks Chrome support (by hardcoding product), I will move this to a config value soon
@zurgeg

zurgeg commented Sep 1, 2021

Copy link
Copy Markdown
Author

Should be good to merge, I haven't tested though.

@zurgeg

zurgeg commented Sep 1, 2021

Copy link
Copy Markdown
Author

Alright, just tested. The title appears but nothing shows on the actual window.

@zurgeg zurgeg marked this pull request as draft September 1, 2021 16:22
@zurgeg

zurgeg commented Sep 1, 2021

Copy link
Copy Markdown
Author

Alright so adding --start-debugger-server did nothing apparently, I will have to do further investigation

@zurgeg

zurgeg commented Sep 1, 2021

Copy link
Copy Markdown
Author

Alright, so it should work with Firefox Nightly, I can't confirm though. If anyone can test, that'd be helpful

@zurgeg

zurgeg commented Sep 1, 2021

Copy link
Copy Markdown
Author

Alright, tried with Dev Edition, doesn't work...
But, upon attempting to screenshot something (in headless mode), it... works? This indicates that the problem is somewhere in the code, time to do some more digging.

@zurgeg

zurgeg commented Sep 1, 2021

Copy link
Copy Markdown
Author

I did some more digging, I tried using puppeteer-core instead of puppeteer in tests, which couldn't reproduce the problem, I'll try on my desktop later to see if that fixes anything

@zurgeg

zurgeg commented Sep 2, 2021

Copy link
Copy Markdown
Author

So I took another look, and it appears to be navigating to networkservice,networkserviceinprocess.com???
image

@zurgeg

zurgeg commented Sep 2, 2021

Copy link
Copy Markdown
Author

Well, turns out that networkserviceinprocess happens to be a flag passed to Firefox, but this raises another question... does Firefox not support this flag? If so, disabling this flag which appears to be there by default could fix our problems

@zurgeg

zurgeg commented Sep 2, 2021

Copy link
Copy Markdown
Author

Upgrading to Puppeteer 3 fixed the title, but it still doesn't display

@zurgeg

zurgeg commented Sep 2, 2021

Copy link
Copy Markdown
Author

Showing the browser window shows that the weird navigation problem I mentioned here is solved, which is progress I guess?

@zurgeg

zurgeg commented Sep 2, 2021

Copy link
Copy Markdown
Author

Using -wait-for-browser allows navigation to work fully, we're getting close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Firefox Support

1 participant