Refactor DefaultClient from constructor-based to Builder pattern for configurable HTTP client options#910
Open
utkrishtsahu wants to merge 1 commit intov4_developmentfrom
Open
Conversation
pmathew92
reviewed
Feb 12, 2026
| private var callTimeout: Int = 0 | ||
| private var defaultHeaders: Map<String, String> = mapOf() | ||
| private var enableLogging: Boolean = false | ||
| private var logLevel: HttpLoggingInterceptor.Level = HttpLoggingInterceptor.Level.BODY |
Contributor
There was a problem hiding this comment.
No need to provide the logLevel option. If the customer wants more control ,they can use a custom logging interceptor
pmathew92
reviewed
Feb 12, 2026
| private var enableLogging: Boolean = false | ||
| private var logLevel: HttpLoggingInterceptor.Level = HttpLoggingInterceptor.Level.BODY | ||
| private var logger: HttpLoggingInterceptor.Logger? = null | ||
| private val interceptors: MutableList<Interceptor> = mutableListOf() |
Contributor
There was a problem hiding this comment.
Lets not add option to configure interceptors . If there is a major request we can add this later .
pmathew92
reviewed
Feb 12, 2026
| * by calling this method multiple times. They are invoked in the order they were added, | ||
| * after the built-in [RetryInterceptor] and before the logging interceptor. | ||
| */ | ||
| public fun addInterceptor(interceptor: Interceptor): Builder = |
pmathew92
reviewed
Feb 12, 2026
| * Only takes effect if [enableLogging] is set to `true`. | ||
| * Default is [HttpLoggingInterceptor.Level.BODY]. | ||
| */ | ||
| public fun logLevel(level: HttpLoggingInterceptor.Level): Builder = |
Contributor
There was a problem hiding this comment.
Lets not add this option
pmathew92
reviewed
Feb 12, 2026
|
|
||
| okBuilder.addInterceptor(RetryInterceptor()) | ||
|
|
||
| interceptors.forEach { okBuilder.addInterceptor(it) } |
Contributor
There was a problem hiding this comment.
Remove the custom interceptors for now
pmathew92
reviewed
Feb 12, 2026
| } else { | ||
| HttpLoggingInterceptor() | ||
| } | ||
| loggingInterceptor.setLevel(logLevel) |
Contributor
There was a problem hiding this comment.
#763
Check the second approach suggested. We can follow that pattern
pmathew92
reviewed
Feb 12, 2026
| /** | ||
| * Internal constructor used by tests to inject SSL and Gson. | ||
| */ | ||
| @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE) |
Contributor
There was a problem hiding this comment.
Can't the tests use the builder now instead of this ?
pmathew92
reviewed
Feb 12, 2026
| .setLevel(HttpLoggingInterceptor.Level.BODY) | ||
| builder.addInterceptor(logger) | ||
| } | ||
| okHttpClient = okHttpClientBuilder.build() |
Contributor
There was a problem hiding this comment.
Wouldn't this create a new client here ? Is this init block required now ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added:
Deprecated:
DefaultClient public constructor (DefaultClient(connectTimeout, readTimeout, defaultHeaders, enableLogging)) — deprecated with @deprecated annotation and ReplaceWith pointing to the Builder API. Still compiles and functions identically; IDE provides one-click quick-fix migration.
Usage:
References
SDK-7763
Testing
Build Passed
Unit Test Passed
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors