Skip to content

fix: upgrade js-cookie to v3 with ES5 transpilation#1667

Merged
amitsingh05667 merged 1 commit into
auth0:masterfrom
vavsab:fix/js-cookie-v3-es5-compat
Jun 24, 2026
Merged

fix: upgrade js-cookie to v3 with ES5 transpilation#1667
amitsingh05667 merged 1 commit into
auth0:masterfrom
vavsab:fix/js-cookie-v3-es5-compat

Conversation

@vavsab

@vavsab vavsab commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Bumps js-cookie to v3.0.7 and adds it to Babel's include list so its modern syntax gets transpiled to ES5, fixing the Compatibility Tests build failure.

@vavsab vavsab requested a review from a team as a code owner June 17, 2026 11:37
@vavsab

vavsab commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Fixes #1658

@vavsab

vavsab commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

@amitsingh05667 Could you pls review, merge and release?

@vavsab

vavsab commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@gyaneshgouraw-okta I would appreciate your help here if possible

@amitsingh05667

amitsingh05667 commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Thanks for raising this PR, @vavsab! I'll take a look. Also, it looks like the branch is outdated, could you please rebase/update it against the latest master?

@vavsab

vavsab commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for raising this PR, @vavsab! I'll take a look. Also, it looks like the branch is outdated, could you please rebase/update it against the latest master?

@amitsingh05667 ✅ Done

@amitsingh05667

amitsingh05667 commented Jun 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@vavsab Please remove all dist/ file changes from this PR. They will be regenerated correctly when a release is cut.

@vavsab vavsab force-pushed the fix/js-cookie-v3-es5-compat branch from ebb8799 to 15c2e8d Compare June 22, 2026 12:07
@vavsab

vavsab commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

@vavsab Please remove all dist/ file changes from this PR. They will be regenerated correctly when a release is cut.

@amitsingh05667 ✅ Done

amitsingh05667
amitsingh05667 previously approved these changes Jun 23, 2026
View reviewed changes
@amitsingh05667 amitsingh05667 enabled auto-merge (squash) June 23, 2026 06:16
@amitsingh05667 amitsingh05667 disabled auto-merge June 23, 2026 06:16
@amitsingh05667 amitsingh05667 self-requested a review June 23, 2026 06:17
@amitsingh05667 amitsingh05667 dismissed their stale review June 23, 2026 06:20

Commit is not verified, dismissing the review.

@amitsingh05667

amitsingh05667 commented Jun 23, 2026

Copy link
Copy Markdown
Member

@vavsab the commit is showing as Unverified ,could you please sign it ?

@vavsab vavsab force-pushed the fix/js-cookie-v3-es5-compat branch from 15c2e8d to b6b4d12 Compare June 23, 2026 15:44
@vavsab

vavsab commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@vavsab the commit is showing as Unverified ,could you please sign it ?

@amitsingh05667 ✅ Done

@amitsingh05667

amitsingh05667 commented Jun 24, 2026

Copy link
Copy Markdown
Member

@vavsab the commit is showing as Unverified ,could you please sign it ?

@amitsingh05667 ✅ Done

@vavsab 😊 We merged another higher-priority PR which caused a conflict with your branch, could you please rebase on the latest master? Also, please make sure your commit is verified/signed. Once both are done, we'll get
this merged today!

@vavsab vavsab force-pushed the fix/js-cookie-v3-es5-compat branch from b6b4d12 to 59aa4f5 Compare June 24, 2026 08:13
@vavsab

vavsab commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

@vavsab the commit is showing as Unverified ,could you please sign it ?

@amitsingh05667 ✅ Done

@vavsab 😊 We merged another higher-priority PR which caused a conflict with your branch, could you please rebase on the latest master? Also, please make sure your commit is verified/signed. Once both are done, we'll get this merged today!

@amitsingh05667 ✅ Done

@amitsingh05667 amitsingh05667 merged commit e359c79 into auth0:master Jun 24, 2026
11 of 13 checks passed
@amitsingh05667 amitsingh05667 mentioned this pull request Jun 24, 2026
Closed
@vavsab vavsab deleted the fix/js-cookie-v3-es5-compat branch June 24, 2026 08:44
@vavsab

vavsab commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

@amitsingh05667 when are you planning to release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amitsingh05667 amitsingh05667 amitsingh05667 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vavsab @amitsingh05667