-
Notifications
You must be signed in to change notification settings - Fork 11
feat: update example schemas shown in playground #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
223d43a to
82f6450
Compare
tstirrat15
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see comment
| definition user {} | ||
| ``` | ||
| Access is granted to all resources of a specific type to a super-admin user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to put a warning on this one - it's a pattern that folks reach for relatively frequently and then they get confused when LRs blow up on them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll do that on a follow-up PR 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, i don't know if i want to put a warning here... this is a learning ground, will that warning scare people off?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd argue that's the place to put it 🤔 Unless you mean you're worried that someone will look at this and say "oh spicedb can't do this thing?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you're looking at this example because you're just looking at the repo, i'd be okay with the warning. but this repo is also shown in the playground. in this case i don't want to show a warning
if the playground didn't source the examples from this repo, then we could solve this..
82f6450 to
cdb00b8
Compare
cdb00b8 to
8a5b2ae
Compare
Description
Updated examples as follows:
document(where it made sense)Testing
zed validateon each YAML