Skip to content

Add parsing of partials and imports #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tstirrat15 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add parsing of partials and imports #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7a3caab
chore: move types to devdeps
tstirrat15 Dec 4, 2025
1e81667
chore: refactor to get rid of as and wrap blocks
tstirrat15 Dec 4, 2025
ccf2722
chore: add tests for partial defs
tstirrat15 Dec 4, 2025
1ec4f60
chore: Fix tests
tstirrat15 Dec 5, 2025
15adfc1
chore: Migrate to use types
tstirrat15 Dec 5, 2025
775ef72
feat: Implement import syntax
tstirrat15 Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions eslint.config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,19 @@ export default tseslint.config(
"@typescript-eslint/no-empty-object-type": "off",
"@typescript-eslint/no-explicit-any": "warn",
"@typescript-eslint/only-throw-error": "off",
"@typescript-eslint/consistent-type-definitions": ["error", "type"],
Copy link
Collaborator Author

@tstirrat15 tstirrat15 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what enforces the preference for type.

"@typescript-eslint/no-unused-vars": [
Copy link
Collaborator Author

@tstirrat15 tstirrat15 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like having this rule around to mark unused things without eslint yelling at you, especially in array destructuring where the syntax would otherwise be [, something,]

"error",
{
args: "all",
argsIgnorePattern: "^_",
caughtErrors: "all",
caughtErrorsIgnorePattern: "^_",
destructuredArrayIgnorePattern: "^_",
varsIgnorePattern: "^_",
ignoreRestSiblings: true,
},
],
"@typescript-eslint/restrict-template-expressions": [
"error",
{ allowNumber: true },
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,13 @@
"dts": true
},
"dependencies": {
"@types/parsimmon": "^1.10.9",
"parsimmon": "^1.18.1"
},
"devDependencies": {
"@arethetypeswrong/cli": "^0.18.2",
"@eslint/js": "^9.39.1",
"@types/node": "^24.10.1",
"@types/parsimmon": "^1.10.9",
Copy link
Collaborator Author

@tstirrat15 tstirrat15 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been in devdeps from the beginning - we don't need this as a part of the exported deps.

"@typescript-eslint/parser": "^8.48.1",
"eslint": "^9.39.1",
"eslint-import-resolver-typescript": "^4.4.4",
Expand Down
6 changes: 3 additions & 3 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading