Skip to content

Conversation

@yabuta
Copy link
Contributor

@yabuta yabuta commented Aug 30, 2022

Description

Add a description of the Calibration Tool being developed in TIER IV.

Releted: https://github.com/tier4/CalibrationTools

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@yabuta
Copy link
Contributor Author

yabuta commented Aug 30, 2022

Translate into English after discussion

@yabuta
Copy link
Contributor Author

yabuta commented Aug 30, 2022

@mitsudome-r
If I explain how to install the calibration tool, would it be better to write it here?
https://autowarefoundation.github.io/autoware-documentation/main/installation/related-tools/

@yabuta yabuta marked this pull request as ready for review August 30, 2022 05:15
@yabuta yabuta marked this pull request as draft August 30, 2022 05:15
@yabuta
Copy link
Contributor Author

yabuta commented Oct 4, 2022

@mitsudome-r @aohsato @knzo25
Can I ask you to first confirm that you would like to review the written content in Japanese?
Also, please give me your opinion on whether or not to add the installation method of the calibration tool to the related tools in the INSTALLATION section in this PR.

@yabuta yabuta marked this pull request as ready for review October 31, 2022 01:13
@yabuta
Copy link
Contributor Author

yabuta commented Oct 31, 2022

@aohsato @mitsudome-r @knzo25
May I first ask for confirmation in Japanese?

@yukkysaito
Copy link
Contributor

yukkysaito commented Jan 29, 2023

@yabuta Looks good.
I would like to merge it once because of the demand, can you please translate it into English? Let's revise again if there are any problems.

@stale
Copy link

stale bot commented Mar 30, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Mar 30, 2023
@knzo25 knzo25 removed their request for review April 1, 2024 02:10
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Apr 1, 2024
@stale
Copy link

stale bot commented Jun 1, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jun 1, 2024
@knzo25
Copy link
Contributor

knzo25 commented Jul 22, 2024

@yabuta
If you are not going to work on this, please close it

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Jul 22, 2024
@stale
Copy link

stale bot commented Sep 20, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Sep 20, 2024
@xmfcx xmfcx force-pushed the add-description-of-tier4-calibration-tool branch from 2d47794 to fb423fd Compare December 1, 2025 12:43
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Dec 1, 2025
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xmfcx xmfcx force-pushed the add-description-of-tier4-calibration-tool branch from fb423fd to ef1a40e Compare December 1, 2025 12:45
@xmfcx
Copy link
Contributor

xmfcx commented Dec 1, 2025

Hi @yabuta -san

I've squashed this into a single commit and rebased it to the latest main branch.

I will now do the basic updates and merge it.

@xmfcx xmfcx force-pushed the add-description-of-tier4-calibration-tool branch from f6fd5d3 to 104a65a Compare December 1, 2025 13:02
@xmfcx xmfcx force-pushed the add-description-of-tier4-calibration-tool branch 2 times, most recently from 3812beb to 0973c63 Compare December 1, 2025 13:28
@xmfcx xmfcx added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Dec 1, 2025
@xmfcx
Copy link
Contributor

xmfcx commented Dec 1, 2025

@yabuta -san I've updated and translated all of it. I think it is ready to merge once the 2 links I asked for are provided.

Please take a final look at it and make modifications if you find it necessary 🙏

@xmfcx xmfcx force-pushed the add-description-of-tier4-calibration-tool branch from 8c366c4 to 75bece2 Compare December 1, 2025 14:11
xmfcx added 7 commits December 2, 2025 11:05
Signed-off-by: Mete Fatih Cırıt <[email protected]>
Signed-off-by: Mete Fatih Cırıt <[email protected]>
Signed-off-by: Mete Fatih Cırıt <[email protected]>
Signed-off-by: Mete Fatih Cırıt <[email protected]>
Signed-off-by: Mete Fatih Cırıt <[email protected]>
Signed-off-by: Mete Fatih Cırıt <[email protected]>
@xmfcx xmfcx force-pushed the add-description-of-tier4-calibration-tool branch from ffddb29 to d79e910 Compare December 2, 2025 08:05
@xmfcx xmfcx merged commit 5c4ac64 into autowarefoundation:main Dec 2, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants