Skip to content

Initial implementaton of ClientEnforcementPolicyBasicAuth#97

Draft
djizatt-avio wants to merge 3 commits into
mainfrom
feature/client-enforcement-policy-custom-context
Draft

Initial implementaton of ClientEnforcementPolicyBasicAuth#97
djizatt-avio wants to merge 3 commits into
mainfrom
feature/client-enforcement-policy-custom-context

Conversation

@djizatt-avio

@djizatt-avio djizatt-avio commented Oct 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • The ClientEnforcementPolicyCustom was existant, but didn't seem to be utilized anywhere
  • I renamed it to ClientEnforcementPolicyCustomAuth to align with the ClientEnforcementPolicyBasicAuth naming standards
  • Added minimum and full policy testing within PolicyContextTest.grooy
  • Updated allOptions.groovy with the new policy configuration
  • I have only tested this within Unit Testing

@github-actions

github-actions Bot commented Oct 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Test Results

325 tests  +3   325 ✅ +3   1m 58s ⏱️ -3s
 40 suites ±0     0 💤 ±0 
 40 files   ±0     0 ❌ ±0 

Results for commit 3447379. ± Comparison against base commit 3931384.

♻️ This comment has been updated with latest results.

@manikmagar manikmagar requested a review from a team as a code owner November 19, 2024 03:38
manikmagar
manikmagar reviewed Nov 19, 2024
View reviewed changes
Comment thread w Outdated

@manikmagar manikmagar Nov 19, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this diff file intentionally added?

@djizatt-avio djizatt-avio Nov 19, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my first time working on the deployer, I think I included this file by mistake, as to my knowledge it isn't needed. I can remove it.

@djizatt-avio djizatt-avio Nov 19, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also need to test this change with a deployment to the AVIO IT Dev space before merging.

@manikmagar manikmagar Nov 20, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. @djizatt-avio please remove this file. If the PR is not ready, you can convert it to Draft for now.

@manikmagar

manikmagar commented Nov 19, 2024

Copy link
Copy Markdown
Contributor

@djizatt-avio does this PR supersede #26?

@djizatt-avio

djizatt-avio commented Nov 19, 2024

Copy link
Copy Markdown
Contributor Author

@manikmagar I believe it does. I saw that PR as well, but I saw it was from 2021 and the updates in my PR seem to conform better to the current standards utilized within the deployer.

@djizatt-avio djizatt-avio marked this pull request as draft November 21, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manikmagar manikmagar manikmagar left review comments
@adesjardin adesjardin Awaiting requested review from adesjardin

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@djizatt-avio @manikmagar