Skip to content

rename vnic_dlpar param interfaces to host_interfaces - #3358

Open
FarooqAbdulla02 wants to merge 1 commit into
avocado-framework-tests:masterfrom
FarooqAbdulla02:vnic_lockdown_modify_file
Open

FarooqAbdulla02 wants to merge 1 commit into
avocado-framework-tests:masterfrom
FarooqAbdulla02:vnic_lockdown_modify_file

Conversation

@FarooqAbdulla02

Copy link
Copy Markdown
Contributor

Rename the "interfaces" param to "host_interfaces" in vnic_dlpar_lockdown.yaml and read it as "host_interfaces" in vnic_dlpar.py setUp() (previously it read "interface", which never matched the YAML key), along with README update.

Comment thread io/net/virt-net/vnic_dlpar.py Outdated
self.local = LocalHost()
self.interface = self.params.get('interface', default=None)
self.host_interfaces = self.params.get('host_interfaces',
default=None)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FarooqAbdulla02 you need to add the below. check, if any one by-mistakenly gives multiple interfaces

if len(self.host_interfaces) > 1 : ----> I feel you still can use self.interface itself
self.interface = self.interface[0]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naresh-ibm updated code to look only first list of item if multiple entries are available.

Rename the "interfaces" param to "host_interfaces" in
vnic_dlpar_lockdown.yaml and read it as "host_interfaces" in
vnic_dlpar.py setUp() (previously it read "interface", which never
matched the YAML key), along with README update.

Signed-off-by: Shaik Abdulla <abdulla1@linux.ibm.com>
@FarooqAbdulla02
FarooqAbdulla02 force-pushed the vnic_lockdown_modify_file branch from 68d3a87 to 7292f8a Compare November 5, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants