Repository navigation
rename vnic_dlpar param interfaces to host_interfaces - #3358
Open
FarooqAbdulla02 wants to merge 1 commit into
Open
FarooqAbdulla02 wants to merge 1 commit into
FarooqAbdulla02 wants to merge 1 commit into
Conversation
Naresh-ibm
requested changes
Nov 5, 2026
| self.local = LocalHost() | ||
| self.interface = self.params.get('interface', default=None) | ||
| self.host_interfaces = self.params.get('host_interfaces', | ||
| default=None) |
Collaborator
There was a problem hiding this comment.
@FarooqAbdulla02 you need to add the below. check, if any one by-mistakenly gives multiple interfaces
if len(self.host_interfaces) > 1 : ----> I feel you still can use self.interface itself
self.interface = self.interface[0]
Contributor
Author
There was a problem hiding this comment.
@Naresh-ibm updated code to look only first list of item if multiple entries are available.
Rename the "interfaces" param to "host_interfaces" in vnic_dlpar_lockdown.yaml and read it as "host_interfaces" in vnic_dlpar.py setUp() (previously it read "interface", which never matched the YAML key), along with README update. Signed-off-by: Shaik Abdulla <abdulla1@linux.ibm.com>
FarooqAbdulla02
force-pushed
the
vnic_lockdown_modify_file
branch
from
November 5, 2026 14:20
68d3a87 to
7292f8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the "interfaces" param to "host_interfaces" in vnic_dlpar_lockdown.yaml and read it as "host_interfaces" in vnic_dlpar.py setUp() (previously it read "interface", which never matched the YAML key), along with README update.