Repository navigation
perf/perf_lock: reduce benchmark workload and remove raw trace dump - #3360
Open
vrbagalkot wants to merge 1 commit into
Open
vrbagalkot wants to merge 1 commit into
vrbagalkot wants to merge 1 commit into
Conversation
The test cases in perf_lock were taking excessively long in CI: - locks_with_entries took ~4 hours because '-D' dumped full raw traces to stdout for millions of events instead of limiting to the top 5 entries. - script hung / timed out because default 'perf bench sched messaging' recorded hundreds of thousands of events across 320 processes, producing over a million lines of callstack traces in 'perf lock script' and flooding the test logger. Fix both issues by: 1. Scaling down 'perf bench sched messaging' to '-g 1 -l 1' so the trace size remains manageable while providing sufficient lock samples. 2. Removing '-D' from the locks_with_entries variant in record_report.yaml. Signed-off-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
perf_locktest suite was experiencing severe execution time issues and hangs in automated test environments / CI:locks_with_entriesvariant took ~4 hours (~14,704s):-D(--dump-raw-trace) flag inrecord_report.yamlinstructedperf lock reportto dump raw event traces to stdout for millions of events instead of just reporting the top 5 entries.-Dfrom thelocks_with_entriesvariant option (-c -E 5).scriptvariant hung / timed out (~50+ minutes):perf bench sched messagingrecording workload generated hundreds of thousands of lock contention tracepoints across 320 processes.perf lock script -f -iresolved symbols and printed full callstacks for every single event, resulting in >1,000,000 lines of output that flooded test runners (OpTest/Avocado) and triggered recovery/hangs.perf bench sched messaging -g 1 -l 1(1 group, 1 loop), which provides sufficient lock events to validate all variants while allowing tests to execute in seconds.Test Results
Before:
locks_with_entries: PASS (14,704.52 s)script/input_data: INTERRUPTED / TIMEOUT (2,970+ s)After: