stone: bump to 2.4.0 - #345
Closed
mobileoverlord wants to merge 1 commit into
Closed
mobileoverlord wants to merge 1 commit into
mobileoverlord wants to merge 1 commit into
Conversation
From 2.3.0. 2.4.0 emits AVOCADO_PARTITION_<NAME>_FLAGS for every partition - 0x0100000000000000 when the manifest says expand: "true" - so the fwup templates can write it as the partition's GPT attribute flags and the initramfs can grow the partition to its disk before /var is opened. It also requires expand: "true" to be the last partition and to be named, in every form rather than only when size is omitted. Every stone manifest in this layer set already satisfies that rule, so the tightened validation rejects nothing here. Cargo.lock carries no dependency change between the pinned revisions, so stone-crates.inc is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
stonefrom 2.3.0 to 2.4.0 (SRCREV= the2.4.0tag commit,9856a61), renaming the recipe to match. Companion to the same bump onwrynose.2.4.0 brings:
provisionemitsAVOCADO_PARTITION_<NAME>_FLAGSfor every partition —0x0100000000000000when the manifest saysexpand: "true",0otherwise — so the fwup templates can write it as the partition's GPT attribute flags. With the bit on the partition, the initramfs can grow it to the disk before/varis opened, which an image written to a file and flashed later cannot do at flash time.expand: "true"must now be the last partition and must be named, in every form rather than only whensizeis omitted.Risk
The validation change is the only thing that can break a build here, and it breaks nothing: all stone manifests in this layer set already put
expandon the last, named partition. Cargo.lock carries no dependency change between the old pin and 2.4.0, sostone-crates.incneeds no regeneration and is untouched.Draft because
Wants a per-machine parse/build check before merge. The consumer side is already hardware-verified on an i.MX 8M Plus board: the
varpartition carriesAttribute flags: 0100000000000000, udev exposesID_PART_ENTRY_FLAGS=0x100000000000000, and the initramfs grow unit reads it and correctly no-ops when the partition already fills the disk.