Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #3502
Description of changes:
SchemaRegistry's three name/map overloads propagate IrRecoverableException from a Kotlin helper without declaring it. Java callers cannot compile a catch for that checked exception even though the call can throw it.
Add @throws to both Kotlin registration helpers, propagate throws through the three Java overloads, and document the failure. Add nine Kotlin regression tests using real ModelSchema objects and JavaCompiler probes; update two existing Java test call chains to handle the declaration.
How did you test these changes?
New regression tests: original source fails the three Java typed-catch probes; patched source passes all nine cases.
Full unit suites: core 172, aws-api-appsync 50, aws-datastore 250; 472 pass, zero failures or skipped tests.
core ktlintCheck, checkstyle and lintDebug pass.
aws-datastore checkstyle and core assembleRelease pass.
Upstream BCV 0.18.2 validates the built Release JAR against core/api/core.api through a temporary external task; the upstream build files and API baseline are unchanged.
JVM signatures across 629 production classes are unchanged. A Java client compiled against the original artifact passes six runtime checks against the patched artifact.
Full-repository
clean buildwas also attempted: the online run was stopped after five minutes waiting in dependency TLS handshakes; an offline retry could not resolve uncached dependencies in other modules, including maplibre-adapter. The full-repository build is therefore not claimed as passing.Java source compatibility
Adding the checked throws declaration changes Java source requirements. An existing client's source reports three previously invisible unhandled exceptions when recompiled against the patched artifact. The corresponding compiled client continues to run.
This source compatibility impact should be considered when choosing the release and exception policy. The patch preserves existing registration behavior. Validation includes 472 passing unit tests, Java compilation probes, and binary compatibility checks. Android device and Flutter end-to-end testing were outside the scope of this validation.
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.