Skip to content

test: add contract tests for converse API#747

Open
ezhang6811 wants to merge 2 commits into
aws-observability:mainfrom
ezhang6811:converse-contract-tests
Open

test: add contract tests for converse API#747
ezhang6811 wants to merge 2 commits into
aws-observability:mainfrom
ezhang6811:converse-contract-tests

Conversation

@ezhang6811
Copy link
Copy Markdown
Contributor

@ezhang6811 ezhang6811 commented May 15, 2026

Issue #, if available:

Description of changes:
Similar to aws-observability/aws-otel-js-instrumentation#450
Add converse contract test to validate upstream behavior and be notified of changes in Converse API support.

The converse_stream test is not included, as botocore is unable to parse a mocked streaming response - it requires a live HTTP connection to construct an EventStream object which our infra cannot provide. This is only covered by the NodeJS contract tests.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ezhang6811 ezhang6811 requested a review from a team as a code owner May 15, 2026 23:32
@ezhang6811 ezhang6811 added the skip changelog doesn't need a CHANGELOG entry label May 15, 2026
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean PR that follows existing patterns well. A few minor observations below.

Comment thread contract-tests/images/applications/botocore/botocore_server.py Outdated
Comment thread contract-tests/tests/test/amazon/botocore/botocore_test.py
Comment thread contract-tests/tests/test/amazon/botocore/botocore_test.py
Comment thread contract-tests/images/applications/botocore/botocore_server.py
@ezhang6811 ezhang6811 changed the title test: add contract tests for converse and converse_stream APIs test: add contract tests for converse API May 16, 2026
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. No bugs or security issues found. This is a clean contract test addition that follows existing patterns correctly. See inline comments for minor nits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog doesn't need a CHANGELOG entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant