Feature/efa ec2 integration test#688
Open
mitali-salvi wants to merge 4 commits into
Open
Conversation
- test/efa_ec2/: Go integration test following nvidia_gpu EC2 pattern - Copies agent config, starts agent, sleeps 2min, stops, validates 9 EFA metrics via CloudWatch API - terraform/ec2/efa/: EFA-specific Terraform module - EFA network interface (interface_type=efa), cluster placement group - Self-referencing security group for EFA OS-bypass - EIP for SSH access, EFA driver installation via aws-efa-installer - Hard failure if EFA device not detected after driver install
- Add ec2_efa to testTypeToTestConfig with testDir=./test/efa_ec2, terraformDir=terraform/ec2/efa - Create ec2_efa_test_matrix.json with AL2023 on c5n.9xlarge
Verify that EFA metrics use short CW-friendly dimension names (device, port, eni_id) instead of OTel-style dotted names (aws.efa.device, aws.efa.port, aws.efa.eni.id).
mitali-salvi
force-pushed
the
feature/efa-ec2-integration-test
branch
from
5754307 to
c541fa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds EFA EC2 integration test with Terraform module and test matrix entry.
Changes
test/efa_ec2/) — validates EFA metrics are published to CloudWatch with correct short dimension names (device,port,eni_id) andInstanceIdfrom append_dimensionsgenerator/resources/ec2_efa_test_matrix.json) — defines AMI and instance config for CIaws.efa.device,aws.efa.port,aws.efa.eni.id) to CW-friendly short namesRelated PRs
Testing
device=rdmap0s31,port=1,eni_id=eni-044b89ddc44b78ea7