ci: declare permissions on the PR-build workflow#2119
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
PR-build runs Go lint + tests with actions/cache@v3 for Go module cache. Needs: contents: read - actions/checkout actions: write - actions/cache save path (cache miss creates new cache entry) Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
arpitjain099
force-pushed
the
ci/add-permissions
branch
from
c1adce1 to
1e155b5
Compare
Author
|
Hi @okankoAMZ, gentle ping on this. PR has been open for 4 days without review. I noticed you've been on the recent-merger side of recent merges in this repo. When you have a moment, would you mind giving it a quick look? No urgency. Happy to address any feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-build.ymlruns Go lint + tests across the matrix withactions/cache@v3for the Go module cache. It is the one workflow in.github/workflows/without an explicitpermissions:block.Scopes:
contents: read—actions/checkoutactions: write—actions/cache@v3save path. The action restores AND saves; once explicit permissions kick in (instead of repo default), the save call needsactions: write.YAML validates.