Repository navigation
Prevent LLMPerf monitor hangs from full subprocess pipes - #4931
Open
lighthuska-lab wants to merge 2 commits into
Open
lighthuska-lab wants to merge 2 commits into
lighthuska-lab wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Related fork issue: lighthuska-lab#2
Description of changes:
Drain stdout and stderr with communicate(timeout=15) while monitoring LLMPerf instead of polling for exit before reading pipes. A verbose child can otherwise fill a pipe and never exit. Preserve progress and nonzero-exit logging; replace invalid UTF-8 for display. Includes offline regressions, documentation, and Python 3.11–3.13 CI.
Testing done:
Four regression tests pass; baseline had two failures and one error. Tests cover timeout retries, nonzero exits, undecodable output, and a real local child writing 1 MiB to each pipe with a five-second watchdog. All nine push/PR jobs passed in the fork, including Black checks and XGBoost regressions from the merged base. git diff --check passes. No LLMPerf workload, AWS endpoint call, or notebook end-to-end test was run.
Merge Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.