Repository navigation
Fix XGBoost regression CSV output dropping batch records - #4932
Open
lighthuska-lab wants to merge 2 commits into
Open
lighthuska-lab wants to merge 2 commits into
lighthuska-lab wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Related fork issue: lighthuska-lab#1
Description of changes:
Serialize every row of the XGBoost prediction/SHAP array as newline-delimited CSV. Previously output_fn serialized predictions[0] only, silently dropping later records. Single-record formatting and unsupported-content-type errors remain unchanged. Includes offline regression tests, documentation, and Python 3.11–3.13 CI.
Testing done:
Four regression tests: two failed against baseline; all four pass with the fix. All six push/PR matrix jobs passed in the fork, including Black formatting checks. Real NumPy arrays and a mocked model test predict_fn-to-output_fn routing. git diff --check passes. No cloud jobs, endpoint calls, or notebook end-to-end tests were run.
Merge Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.