Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #594 +/- ##
=========================================
Coverage 65.38% 65.38%
Complexity 211 211
=========================================
Files 34 34
Lines 988 988
Branches 142 142
=========================================
Hits 646 646
Misses 290 290
Partials 52 52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
992cf9f to
ad53eb0
Compare
ad53eb0 to
4c81a80
Compare
ClasspathLoaderTest (JDK 25 split), UnsafeUtilTest (Unsafe.getObjectVolatile rewrite), and the JDK version matrix in the RIC PR workflow are moved to the dmelfi/improve-action-speed branch. This branch keeps only CI/workflow improvements and the JUnit 5.14.3 upgrade.
0b032a6 to
2c29a69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Fix multi-JDK test compatibility for
UnsafeUtilTestandClasspathLoaderTestin the Runtime Interface Client, and upgrade JUnit Jupiter from 5.9.2 to 5.14.3.UnsafeUtilTest —
testDisableIllegalAccessWarning:setAccessible(true)(standard reflection) to verify a field that production code accesses viaUnsafe— this broke on JDKs where the production code works fine.Unsafe.getObjectVolatile/staticFieldOffsetto mirror production code (no--add-opensneeded), and added@EnabledForJreRange(min = JAVA_9, max = JAVA_16)sinceIllegalAccessLoggeronly exists on JDK 9-16.ClasspathLoaderTest —
testLoadAllClassesWithEmptyClasspath:new File("").exists()now returnstrue(resolves to cwd) due to JDK-8024695. This meansClasspathLoaderno longer throwsFileNotFoundExceptionfor an empty classpath entry — it hits the directory-skip path instead.@DisabledForJreRange(min = JAVA_25)/@EnabledForJreRange(min = JAVA_25).JUnit upgrade: 5.9.2 → 5.14.3 to get
JRE.JAVA_25enum support for precise test targeting.Tests verified passing on JDK 8, 11, 17, and 21.
CI workflow improvements:
actions/cache) to all workflows.workflow_dispatchto all workflows for manual triggering.CI dependency graph for reference:
Design principles:
Target (OCI, Managed Runtime, both):
Both
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.