Skip to content

[E2E Test Visibility] Fix TestMetadata UUID reuse causing DynamoDB records to be overwritten#7339

Merged
hehe7318 merged 2 commits intoaws:developfrom
hehe7318:wip/fix-ddb-metadata-uid
Apr 16, 2026
Merged

[E2E Test Visibility] Fix TestMetadata UUID reuse causing DynamoDB records to be overwritten#7339
hehe7318 merged 2 commits intoaws:developfrom
hehe7318:wip/fix-ddb-metadata-uid

Conversation

@hehe7318
Copy link
Copy Markdown
Contributor

Description of changes

Previously the UUID is computed once at module load time. When a worker runs test A then test B, both get the same DynamoDB key, and B's put_item overwrites A's record.

Now it generates a new UUID per instance.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hehe7318 hehe7318 requested review from a team as code owners April 15, 2026 20:09
@hehe7318 hehe7318 added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Apr 15, 2026
@hehe7318 hehe7318 changed the title [E2E Test] Fix TestMetadata UUID reuse causing DynamoDB records to be overwritten [E2E Test Visibility] Fix TestMetadata UUID reuse causing DynamoDB records to be overwritten Apr 15, 2026
hanwen-cluster
hanwen-cluster previously approved these changes Apr 16, 2026
@hanwen-cluster hanwen-cluster dismissed their stale review April 16, 2026 14:09

Are you sure the new change can guarantee consistent UUID with in a single test?

Copy link
Copy Markdown
Contributor Author

@hehe7318 hehe7318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answer Hanwen's question:
Regarding the setup, call, and teardown phases, the code creates the TestMetadata object only once during the setup phase, so there are no issues here. See the code at: https://github.com/aws/aws-parallelcluster/blob/develop/tests/integration-tests/conftest_utils.py#L184-L231

@hehe7318 hehe7318 merged commit 0e09e5f into aws:develop Apr 16, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x skip-changelog-update Disables the check that enforces changelog updates in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants