[Validators] The validator ClusterNameValidator now enforces cluster names to be limited to 40 characters when using ExternalSlurmdbd.#7340
Merged
gmarciani merged 1 commit intoaws:developfrom Apr 16, 2026
Conversation
…r names to be limited to 40 characters when using `ExternalSlurmdbd`. This is consistent with the existing limit for `Database`. This limitation prevents runtime failures caused by MySQL's table name length limit.
fa582bd to
d6e6867
Compare
hanwen-cluster
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The validator
ClusterNameValidatornow enforces cluster names to be limited to 40 characters when usingExternalSlurmdbd. This is consistent with the existing limit forDatabase.This limitation prevents runtime failures caused by MySQL's table name length limit.
what if we do not enforce this limit?
Without enforcing this limit the user may have hard time understanding the root cause of the failure.
The cluster creation would succeed but acccunting data would not be pushed.
The user must check slurmdbd logs to spot the issue, signaled by this error line:
We did not change the error message because it was already comprehensive:
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.