Skip to content

[integ-tests] Check there is no defunct Slurm parameters#7342

Open
hanwen-cluster wants to merge 1 commit intoaws:developfrom
hanwen-cluster:developapr15
Open

[integ-tests] Check there is no defunct Slurm parameters#7342
hanwen-cluster wants to merge 1 commit intoaws:developfrom
hanwen-cluster:developapr15

Conversation

@hanwen-cluster
Copy link
Copy Markdown
Contributor

@hanwen-cluster hanwen-cluster commented Apr 16, 2026

Description of changes

  • This check is added to Slurm accounting tests, because they contain more Slurm parameters than other tests

Tests

The following tests have passed

{%- import 'common.jinja2' as common with context -%}
{{- common.OSS_COMMERCIAL_X86.append("rocky8") or "" -}}
{{- common.OSS_COMMERCIAL_X86.append("rocky9") or "" -}}
---
test-suites:
  schedulers:
    test_slurm_accounting.py::test_slurm_accounting:
      dimensions:
        - regions: ["ap-south-1"]
          instances:  {{ common.INSTANCES_DEFAULT_X86 }}
          oss: ["alinux2023"]
          schedulers: ["slurm"]
    test_slurm_accounting.py::test_slurm_accounting_external_dbd:
      dimensions:
        - regions: [ "ap-south-1" ]
          instances: {{ common.INSTANCES_DEFAULT_X86 }}
          oss: ["ubuntu2404"]
          schedulers: ["slurm"]

References

aws/aws-parallelcluster-cookbook#3165 should be merged before this PR

Github issue: #7319

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This check is added to Slurm accounting tests, because they contain more Slurm parameters than other tests
Copy link
Copy Markdown
Contributor

@gmarciani gmarciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job adding this check!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants