[release-0.24] Update custom TinkerbellTemplateConfig to use new static IPAM logic #10340
Conversation
The custom template in TestTinkerbellCustomTemplateRefSimpleFlow was using the deprecated STATIC_NETPLAN environment variable approach which was removed in PR aws#10163. That PR changed the templating logic to directly configure IPAM using netplan or NetworkManager by referencing the Hardware object's network metadata. This commit updates the custom template to: - Remove STATIC_NETPLAN environment variable - Add CONTENTS with Go template expressions that access network details directly from .Hardware.Interfaces[0].DHCP fields - Support both VLAN and non-VLAN configurations using conditional logic - Use netmaskToCIDR template function for proper CIDR notation - Maintain the custom cexec action for test validation The updated template now follows the same pattern as the default template generation in NewDefaultTinkerbellTemplateConfigCreate, specifically mirroring the withNetplanAction() function for Ubuntu OS family. Ref: aws#10163
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @eks-distro-pr-bot. Thanks for your PR. I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
eks-distro-bot
added
the
size/M
4 participants
This is an automated cherry-pick of #10338
/assign panktishah26