Add nodeSelector, tolerations and affinity support for pod assignment in AWS SIGv4 Admission Controller #1230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnment in AWS SIGv4 Admission Controller
Author
|
@oliviassss @jaydeokar could you please review? |
Author
|
Hello @dims |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Support of tolerations and node selectors in aws-sigv4-proxy-admission-controller/ #1229
Description of changes
This PR adds nodeSelector, tolerations and affinity support for pod assignment in AWS SIGv4 Admission Controller
Checklist
README.mdfor modified charts)versioninChart.yamlfor the modified chart(s)Testing
Was able to install HELM chart with properly passed nodeSelector, tolerations and affinity parameters.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.