aws-load-balancer-controller: Add support for dnsConfig in deployment.yaml #1234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitinverma9
force-pushed
the
feature-add-dnsConfig
branch
from
8efb04c to
6f72e0d
Compare
….yaml. This is supported as a standard pattern across various public helm charts, so decided to make a PR here.
nitinverma9
force-pushed
the
feature-add-dnsConfig
branch
from
6f72e0d to
e43f188
Compare
Author
|
Hello @shraddhabang can this be merged anytime soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Unable to set dnsConfig for pods
Description of changes
Adding in the ability to specify dns configuration for the aws-load-balancer-controller pods
Checklist
README.mdfor modified charts)versioninChart.yamlfor the modified chart(s)Testing
Deployed a version of the load-balancer controller in a test environment, by manually editing the deployment.yaml to include dnsConfig with options parameters of ndots as 1 and attempts as 3. Default value for
ndotsis 5, which means for dns resolution it sequentially go through all the local search domains first in /etc/resolv.conf and if none succeed, it will resolve it as an absolute name only at last, which can negatively affect app performanceBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.