Fix: Distract spell stops target movement #23479
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Distract spell was causing the target to stop moving because it was forcing the target to face the caster. This was happening because the `SetFacingTo` function in `Spell::EffectDistract` was clearing the movement stack. This commit fixes the bug by removing the call to `SetFacingTo`, which prevents the movement stack from being cleared. A test case has been added to verify that the original movement is not interrupted.
github-actions
bot
added
CORE
Contributor
|
Did you also test that Distract still forces the targets to face the caster? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Distract spell was causing the target to stop moving because it was forcing the target to face the caster. This was happening because the
SetFacingTofunction inSpell::EffectDistractwas clearing the movement stack.This commit fixes the bug by removing the call to
SetFacingTo, which prevents the movement stack from being cleared. A test case has been added to verify that the original movement is not interrupted.